Authorization for Queue and Token Endpoints #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made gh action trigger on PRs also to get around stuck status checks (#19) * Made gh action trigger on PRs also to get around stuck status checks * Modified to trigger only on PRs * Renamed check * Add Token to Queue (#18) * implemented add token for queue store * implemented create token route * Fix code style issues with gofmt * read tokens in the queue in readqueue * Fix code style issues with gofmt * implemented token number * Fix code style issues with gofmt * added read token route * Fix code style issues with gofmt * separated name length constants * log insert error for add token * Fix code style issues with gofmt * refactoring mongo store * Fix code style issues with gofmt Co-authored-by: Lint Action <[email protected]> Co-authored-by: Nithin <[email protected]> Co-authored-by: Lint Action <[email protected]>
daltonfury42
previously approved these changes
Mar 28, 2022
internal/handler/queue.go
Outdated
| @@ -123,9 +122,26 @@ func DeleteQueue(w http.ResponseWriter, r *http.Request) { | |||
| w.WriteHeader(http.StatusOK) | |||
| } | |||
|
|
|||
| func QueueCtx(next http.Handler) http.Handler { | |||
| func QueueMiddlware(next http.Handler) http.Handler { | |||
There was a problem hiding this comment.
I was trying to think of a good name for this middleware. QueueOwnerAuthMiddleware?
There was a problem hiding this comment.
Ok
Then I'll also rename TokenMiddleware to TokenOwnerAuthMiddleware
daltonfury42
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented authorization for queue -
uidReadQueue/queue/{id}endpointsImplemented authorization for token -
As discussed with @daltonfury42 we might need a shallow
ReadQueuelater which any user can read basic information about the queue from.