Implemented Authentication Middelware #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made gh action trigger on PRs also to get around stuck status checks (#19) * Made gh action trigger on PRs also to get around stuck status checks * Modified to trigger only on PRs * Renamed check * Add Token to Queue (#18) * implemented add token for queue store * implemented create token route * Fix code style issues with gofmt * read tokens in the queue in readqueue * Fix code style issues with gofmt * implemented token number * Fix code style issues with gofmt * added read token route * Fix code style issues with gofmt * separated name length constants * log insert error for add token * Fix code style issues with gofmt * refactoring mongo store * Fix code style issues with gofmt Co-authored-by: Lint Action <[email protected]> Co-authored-by: Nithin <[email protected]> Co-authored-by: Lint Action <[email protected]>
| @@ -21,5 +21,5 @@ build/ | |||
| # temporary build files create by air | |||
| tmp/ | |||
|
|
|||
| # dotenv variables | |||
| # env file | |||
| .env | |||
There was a problem hiding this comment.
Why should this be gitignored?
If it's okay, let's checkin the default .env file, it will be easier for others to run the code my making minimal edits.
There was a problem hiding this comment.
It shouldn't be a problem right now. But since we also store secrets as env variables, I just added it to gitignore. Also, I think generally most projects keep .env in .gitignore.
There was a problem hiding this comment.
I think it would be better to store these values as constants inside a go file instead of committing the .env file to git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented an authentication middleware.
Anonymous <anonymous-uuid>then,<anonymous-uuid>is used as the ID for the userBearer <jwt-token>then,<jwt-token>is decoded using auth0 and the "sub" claim from the decoded token is used as the ID for the useruidin the contextWe can then use the
uidas the owner of the queue inCreateQueueetc.The following environment variables need to be set in order for the middlware to work
I am making use of
godotenvto load these variables from a.envfile for development purposes. When deploying we will need to set these variables accordingly.