Added read, pause, resume and delete for queue #15
Conversation
There was a problem hiding this comment.
@aneeshsharma pl review, you are the golang/mongo expert here. ✌️
internal/datastore/mongo_store.go
Outdated
| } | ||
|
|
||
| func (mongodb MongoDB) PauseQueue(models.QueueId) { | ||
| panic("Not implemented") | ||
| func (mongodb MongoDB) PauseQueue(id models.QueueId) { |
There was a problem hiding this comment.
The code for this function and resume function is identical.
Let's have one setIsPaused(id models.QueueId, isPaused boolean) private function and then call it with true/false in PauseQueue/ResumeQueue
There was a problem hiding this comment.
Added setIsPaused()
internal/handler/queue.go
Outdated
| json.NewEncoder(w).Encode(q) | ||
| fmt.Fprintf(w, "Get queue") |
There was a problem hiding this comment.
what does line 24 do? Why do we need both lines 23 and 24?
There was a problem hiding this comment.
You are right. Line 24 is not needed. I will remove it.
…plQ/simplQ-golang into sijin-q-funcs-implementation
internal/handler/queue.go
Outdated
| fmt.Fprintf(w, "GET Queue not implemented") | ||
| id := r.Context().Value("id").(string) | ||
| if id == "" { | ||
| http.Error(w, fmt.Sprintf("Invalid Id: %s", id), 404) |
There was a problem hiding this comment.
Could you replace the status code numerical values with constants from the http package:
400 -> hhtp.StatusBadRequest, 404 -> http.StatusNotFound to make it a bit more explicit and less error prone?
There was a problem hiding this comment.
Hey, did you forget to push your commits? I don't see any changes.
There was a problem hiding this comment.
Apologies. I have pushed now.
Added queue functions based on Chi router. Kindly review.