Add asrock ep2c612ws support #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a similar change for ipmi2json to add support, but I wanted to get feedback on the main one first. |
|
Sorry only just seen the pr will take a look. Can you move the board model to the ipmi_check include file? |
|
I have added changes to my next release. You can test from here https://raw.githubusercontent.com/SimonFair/IPMI-unRAID/Dell-support/plugin/ipmi.plg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally written this patch against the previous maintainer's version, but they never looked into it. These are the changes I made to make it work with my motherboard (as well as fix a bug in the process hanging while calling autofan)
Then I cleaned up the whitespace to be consistent across the file.
I isolated the fix around a call to the motherboard model and checking to see if it matches, so it shouldn't effect any other board.