[FEATURE] [MER-3782] no payment feature #5340
Open
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrensiegel
requested changes
Jan 8, 2025
There was a problem hiding this comment.
I'm concerned that we are using the cost being 0 as a paywall bypass mechanism.
This will preclude use cases such as a paywall guarding a section with access codes and a $0 cost
If what we are really intending to build (according to the ticket) is a mechanism for an institution to bypass completely the default paywall (since it is being offered for free at the institution), we should be modeling that explicitly by adding a new "Bypass paywall" or "Offer this for free" in the Discount impl ( Oli.Delivery.Paywall.Discount)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where users registered into a course that requires payment are still redirected to a payment provider even when the price is zero. The implementation adds a new paywall bypass for cases where the amount listed in the course is zero.