-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config_sample.env #274
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: bnfowne9i <[email protected]>
Reviewer's Guide by SourceryThis appears to be an empty diff for config_sample.env. While the file is mentioned in the changes, no actual modifications (additions or deletions) are shown in the provided diff. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bnfowne9i - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Real Telegram Bot Token exposed in config file (link)
- Telegram API Hash exposed in config file (link)
- Telegram User Session String exposed in config file (link)
Overall Comments:
- This PR appears to be incomplete - there are no visible changes in the diff. Please verify your changes and update the PR with the intended modifications to config_sample.env.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 3 blocking issues
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
OWNER_ID = "" # Require restart after changing it while bot running | ||
TELEGRAM_API = "" # Require restart after changing it while bot running | ||
TELEGRAM_HASH = "" # Require restart after changing it while bot running | ||
BOT_TOKEN = "7657770303:AAFcyp2ebSw6LBYKXx-5-Nffr6JD__oW9Pg" # Require restart after changing it while bot running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Real Telegram Bot Token exposed in config file
This appears to be a real Telegram Bot Token. These should never be committed to source control, even in sample files. Please replace with a placeholder value.
BOT_TOKEN = "7657770303:AAFcyp2ebSw6LBYKXx-5-Nffr6JD__oW9Pg" # Require restart after changing it while bot running | ||
OWNER_ID = "6434831584" # Require restart after changing it while bot running | ||
TELEGRAM_API = "28789183" # Require restart after changing it while bot running | ||
TELEGRAM_HASH = "3dc29da97738fe42da9e8f2524169a9c" # Require restart after changing it while bot running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Telegram API Hash exposed in config file
This appears to be a real Telegram API Hash. API credentials should never be committed to source control. Please replace with a placeholder value.
|
||
# OPTIONAL CONFIG | ||
USER_SESSION_STRING = "" # Require restart after changing it while bot running | ||
USER_SESSION_STRING = "BQCyNwMAFMss2s8QTTFVkIMsqy-gf6ZUQEmpkkQ5vnXhPlsJ6tyrKAleLhW0asQ-1PcN3-PkowpnqPjFzIwALK-WM4YRKbNQGu1IJ4iWJ-5daLUWvAouM34TWk7Su1D0E54bQVczGjZqTT3v8HhpO7D_BWXqhmojqYQWp_Py24oKcszYPfilsH0fSPbKCvSY1GzaO-T-kNASgOQudXTBjsfSfQXsalzvO2rdPlSION7Hzntt60Nigrr-w21R8D9JWNJyE1QMpYbhNRSuco16JRaiqFa2efDB8_wsUTsIdBD5JqkcQCFlhOLKGu47JoiZodG5OgqoDvfgQa3kOREbochNqgvRrAAAAAFxMeNwAA" # Require restart after changing it while bot running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Telegram User Session String exposed in config file
This appears to be a real Telegram User Session string. Session tokens should never be committed to source control as they can be used to access the user's account.
Summary by Sourcery
Update the sample environment configuration file to reflect the latest configuration settings.