Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Add text length limit when displaying Graph & Block name with different length in different places #8746

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Nov 22, 2024

This is a cosmetic change, different place looks better on different text lengths for display. This also avoids text spilling over making the padding size look uneven between entries.

image image

Changes 🏗️

  • Set text length limit in different places.
  • Make the Scrollable component horizontally scrollable.

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

…me with different length in different places
@majdyz majdyz requested a review from a team as a code owner November 22, 2024 10:26
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Nov 22, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Potential UI Bug
The scroll-area component has both overflow:scroll style and overflow-hidden class which may cause unexpected scrolling behavior

Code Smell
The TextRenderer component accepts 'any' type for value parameter which could lead to runtime errors. Consider adding proper type constraints

UI Consistency
Different truncation limits are used in different places (45 chars for name, 165 for description). Consider standardizing these limits or making them configurable

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 3b7178b
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67405c753bf9080008aeea93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant