-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery Time Estimation #113
base: master
Are you sure you want to change the base?
Conversation
Forgot to squash |
Uh sorry about that. It looks like you can squash it when you merge. Haven't done one of these in a while. |
Can you please remove the changes to package.json? Since they have nothing to do with this PR. |
yeah, no problem. i will do that first thing tomorrow. |
okay, commit should be ready to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the plugin could publish socHigh and socLow also as data, so that they would be available for all downstream apps.
Another way to use this data would be to make them available as zones
. This way for example a batteryt gauge could use them to visualise the low and high limits.
The specification has also https://signalk.org/specification/1.7.0/doc/vesselsBranch.html#vesselsregexpelectricalbatteriesregexpcapacitydischargelimit but the unit is joules, which is quite unpractical, SoC figures are much better.
time_to_empty = Math.round(capacity * 60 * 60 * soc_remaining / p) | ||
} | ||
output.push({ | ||
path: 'electrical.batteries.' + instance + '.capacity.timeToEmpty', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specification has timeRemaining - is this it or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This thing still alive?
Added capacity.timeToEmpty and capacity.TimeToFull estimation based on battery power, capacity, and configurable full/empty SOC values.