Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to accomodate ShipModul Miniplex #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jprotzman
Copy link

The Shipmodul Miniplex now uses R and C to represent a message being received or sent. This update adds C to each PSMDST message so that the Miniplex will accept the message.

Example: $PSMDST,C,XX,YY,ZZ

The Shipmodul Miniplex now uses R and C to represent a message being received or sent. This update adds C to each PSMDST message so that the Miniplex will accept the message.

Example: $PSMDST,C,XX,YY,ZZ
@sbender9
Copy link
Member

sbender9 commented Dec 2, 2022

Is this message only used by the Shipmodule stuff? And what about people that haven't updated their firmware?

This change will include both the original PSMDST and the new PSMDST with C based on ShipModul current firmware.
@jprotzman
Copy link
Author

I just added a new commit that will keep the original and include the new version for the current ShipModul firmware. This should accommodate everyone.

@sbender9
Copy link
Member

sbender9 commented Dec 2, 2022

Do we know that it will ignore the wrong one? Just worried that it might do something strange.

@jprotzman
Copy link
Author

I know the Miniplex will ignore the one that does not match its firmware but I cannot say if any other device would do the same. I would think yes since the structure puts an R or a C into the field that would normally be a two character hex value representing the ST datagram. Since R or C are are not represented as a two digit hex value then I would think it would reject the message.

Since I do not have any other devices that accept this message (I don't even know of other devices that would), I cannot test this.

The only definitive alternative would be to add a config setting for the Miniplex.

@tkurki
Copy link
Member

tkurki commented May 3, 2023

Would it make sense to add a new autopilot type Raymarine Seatalk 1 AP (MiniPlex) here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants