Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store EventLoop in a shared_ptr #781

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Store EventLoop in a shared_ptr #781

merged 1 commit into from
Nov 3, 2024

Conversation

mairas
Copy link
Collaborator

@mairas mairas commented Oct 30, 2024

Strictly speaking, this is a breaking change, but since the impact should be quite limited and it removes a major use case of raw pointers, I'll just keep quiet and do it. Naughty me.

Strictly speaking, this is a breaking change, but since the
impact should be quite limited and it removes a major use case of
raw pointers, I'll just keep quiet and do it. Naughty me.
Base automatically changed from restore_threshold_transform to main November 3, 2024 15:39
@mairas mairas force-pushed the event_loop_shared_ptr branch from ba56316 to 894bbdd Compare November 3, 2024 15:39
@mairas mairas merged commit 85336c1 into main Nov 3, 2024
14 checks passed
@mairas mairas deleted the event_loop_shared_ptr branch November 3, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant