Skip to content

Commit

Permalink
Make Qt6 default buils [deploy]
Browse files Browse the repository at this point in the history
  • Loading branch information
dougmassay committed Sep 4, 2023
1 parent 227daa7 commit e6442b8
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 14 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/linux-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ on:
- '.retired_travis.yml'
- '.retired_appveyor.yml'
- '**.md'
- '**/reset-**-caches.txt'

pull_request:
branches: [ master ]
Expand All @@ -31,15 +30,14 @@ on:
- '.retired_travis.yml'
- '.retired_appveyor.yml'
- '**.md'
- '**/reset-**-caches.txt'

env:
BUILD_TYPE: Debug

jobs:
build:
if: "!contains(github.event.head_commit.message, '[skip ci]')"
runs-on: ubuntu-20.04
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
Expand All @@ -54,9 +52,9 @@ jobs:
- name: Install Qt
uses: jurplel/install-qt-action@v3
with:
version: '5.9.5'
version: '6.5.2'
dir: ${{runner.workspace}}/Qt
modules: 'qtwebengine'
modules: 'qtwebengine qtpositioning qt5compat qtpdf qtwebchannel'
setup-python: 'true'
cache: ${{ steps.cache-qt.outputs.cache-hit }}

Expand All @@ -76,5 +74,6 @@ jobs:
run: |
cmake $GITHUB_WORKSPACE \
-G "Ninja" \
-DCMAKE_PREFIX_PATH="{$QT_ROOT_DIR}/lib/cmake" \
-DCMAKE_BUILD_TYPE=$BUILD_TYPE
ninja -j$(getconf _NPROCESSORS_ONLN)
1 change: 0 additions & 1 deletion .github/workflows/mac-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ jobs:
run: |
cmake -DCMAKE_OSX_DEPLOYMENT_TARGET=11 \
-DCMAKE_BUILD_TYPE=Release \
-DUSE_QT6=1 \
-DCMAKE_CXX_FLAGS=-Wno-inconsistent-missing-override \
-DCMAKE_PREFIX_PATH=${{runner.workspace}}/${{env.QT}}/lib/cmake \
-DCMAKE_OSX_SYSROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/ $GITHUB_WORKSPACE
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/reset-lin-caches.txt
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
Change the content of this file to reset the caches for the github actions sigil linux build

reset cache on 4 September 2023
1 change: 1 addition & 0 deletions .github/workflows/reset-win-caches.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ Change the content of this file to reset the caches for the github actions sigil

reset cache on 26 July 2023
reset cache on 26 August 2023
reset cache on 4 September 2023
7 changes: 2 additions & 5 deletions .github/workflows/win-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,11 @@ jobs:
working-directory: ${{runner.workspace}}\build
run: |
set PATH=${{runner.workspace}}\%QT%\bin;%PATH%
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 -vcvars_ver=14.35
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 -vcvars_ver=14.37
echo %PATH%
cmake %GITHUB_WORKSPACE% ^
-G "Ninja" ^
-DCMAKE_BUILD_TYPE=%BUILD_TYPE% ^
-DUSE_QT6=1 ^
-DQt6_DIR="${{runner.workspace}}\$QT\lib\cmake\Qt6" ^
%CMAKE64BIT%
ninja -j2
Expand All @@ -96,11 +95,9 @@ jobs:
set REDIST=C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Redist\MSVC\%RedistVersion%\vc_redist.x64.exe
echo "%REDIST%"
cp '%REDIST%' %GITHUB_WORKSPACE%\installer\vcredist_x64.exe
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 -vcvars_ver=14.35
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 -vcvars_ver=14.37
ninja -j2 deployinstaller
- uses: actions/upload-artifact@v3
if: "contains(github.event.head_commit.message, '[deploy]')"
with:
Expand Down
6 changes: 3 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ add_subdirectory( gumbo_subtree/src )
# Pull in th proper cmake file depending on whether
# a qt5 or qt6 build was requested (defaults to qt5)

if (${USE_QT6})
include(CMakeLists6.txt)
else()
if (${USE_QT5})
include(CMakeLists5.txt)
else()
include(CMakeLists6.txt)
endif()

0 comments on commit e6442b8

Please sign in to comment.