Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chi2 does not take plane rotation into account #35

Open
DavidLP opened this issue Aug 22, 2016 · 2 comments
Open

Chi2 does not take plane rotation into account #35

DavidLP opened this issue Aug 22, 2016 · 2 comments
Labels

Comments

@DavidLP
Copy link
Collaborator

DavidLP commented Aug 22, 2016

Since the planes are now rotated the chi 2 is calculated wrong. The assumption was that the planes are not tilted which is not the case anymore. Also see #34.

This will overestimate the chi2 but should generally not give a chi 2 that is too off. Thus has to me a low priority.

@laborleben
Copy link
Collaborator

Similar case:

intersection = offset + slope / slope[:, 2, np.newaxis] * (z_positions[actual_dut] - offset[:, 2, np.newaxis]) # intersection track with DUT plane

@DavidLP
Copy link
Collaborator Author

DavidLP commented Jan 19, 2017

Similar case:

The similar case does not exist anymore. All result function properly calculate the intersections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants