Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of slope #34

Closed
laborleben opened this issue Aug 22, 2016 · 5 comments
Closed

Calculation of slope #34

laborleben opened this issue Aug 22, 2016 · 5 comments
Labels

Comments

@laborleben
Copy link
Collaborator

laborleben commented Aug 22, 2016

  1. should the slope vector be a normalized vector? See
    return datamean, slope, chi2
  2. What about
    intersections = offset + slope / slope[2] * (hits.T[2][:, np.newaxis] - offset[2]) # Fitted line and DUT plane intersections (here: points)
    , where the slope vector is divided by its third component?
@laborleben
Copy link
Collaborator Author

laborleben commented Aug 22, 2016

addressing 2. Ok, this is clear to me when you assume that the plane is parallel to x-y-plane.
But for the real chi2 we need the rotated plane, which is usually not parallel to the x-y-plane.

@DavidLP
Copy link
Collaborator

DavidLP commented Aug 22, 2016

Well spotted, I opened a bug report #35.

@DavidLP
Copy link
Collaborator

DavidLP commented Aug 22, 2016

  1. We can normalize the direction vector of the track (slope), but we do not have to.

@DavidLP DavidLP changed the title calculation of slope Calculation of slope Aug 22, 2016
@laborleben
Copy link
Collaborator Author

laborleben commented Aug 22, 2016

OK, I see, I'll check if the normalization has some influence on further data processing.

@DavidLP
Copy link
Collaborator

DavidLP commented Aug 23, 2016

Questions answered.

@DavidLP DavidLP closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants