Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick search implementation #7

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Conversation

jespr
Copy link
Contributor

@jespr jespr commented Dec 14, 2023

@Shpigford A quick search implementation to get us started (#2).

  • Extracted the favorites query in gemfiles_controller to a scope on the model, that way we can re-use it on the list of gemfiles AND in the search results.
  • Extracted the gemfile list item used on gemfiles#index to a partial so we can use it on the search page (which required the favorites extraction mentioned previously)
CleanShot.2023-12-14.at.09.18.34.mp4

@claudey
Copy link

claudey commented Dec 16, 2023

Looks good @jespr. I was a bit late to the party https://github.com/claudey/gemfile.directory/tree/gemfile-search

@jespr
Copy link
Contributor Author

jespr commented Dec 16, 2023

@claudey looks good :)

@Shpigford Shpigford merged commit 41b4246 into Shpigford:main Dec 18, 2023
@Shpigford
Copy link
Owner

Thank you so much, @jespr! Merged and deploying now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants