Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made flex and flexChildren available again #2546

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

js-goupil
Copy link
Contributor

Background

Our Stack implementation on POS still has some limitations when it comes to avoiding flex and flexChildren. For example, we don't have any way to implement JustifyItems right now which would let the buttons and other components stretch across the main axis, so we still need flexChildren to accomplish this. As for flex, we need to expose this property so that partners can tell the Stack to take the whole screen if they want. Ideally in the future we refactor our Screen implementation to be flex independent, but this will take time and work that we don't have the capacity for right now.

Solution

Removes the deprecation warnings for flex and flexChildren. It also fixes up some documentation.

🎩

  • ...

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@js-goupil js-goupil merged commit d2bf2b0 into unstable Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants