Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Njo/revert event target #2543

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Njo/revert event target #2543

merged 2 commits into from
Dec 18, 2024

Conversation

NathanJolly
Copy link
Contributor

Background

This backs off the new observe target stuff. We should use it as a reference for when we want to re-add it though!

Solution

Simple revert

@NathanJolly NathanJolly self-assigned this Dec 18, 2024
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

Copy link

@egenerat egenerat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks good to me, not tested

@NathanJolly NathanJolly merged commit a566cd8 into unstable Dec 18, 2024
6 checks passed
@NathanJolly NathanJolly deleted the njo/revert-event-target branch December 18, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants