Undeprecated necessary props

Shopify · Dec 20, 2024 · ad0ebc5 · ad0ebc5
1 parent 126308a
commit ad0ebc5
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/packages/ui-extensions/src/surfaces/point-of-sale/render/components/Stack/Stack.ts b/packages/ui-extensions/src/surfaces/point-of-sale/render/components/Stack/Stack.ts
@@ -21,6 +21,7 @@ type DeprecatedStackDirection = 'vertical' | 'horizontal';
 export interface StackProps extends PaddingProps, SizingProps, GapProps {
   /**
    * Sets how the Stack's children are placed within the Stack.
+   * 'vertical' and 'horizontal' are deprecated. Using these values will use the Stack implementation from 2024-10.
    *
    * @default 'inline'
    */
@@ -43,20 +44,20 @@ export interface StackProps extends PaddingProps, SizingProps, GapProps {
   justifyContent?: ContentPosition | ContentDistribution;
 
   /**
-   * Aligns the Stack's children along the cross axis.
+   * Aligns the Stack along the cross axis.
    *
-   * @see https://developer.mozilla.org/en-US/docs/Web/CSS/align-items
+   * @see https://developer.mozilla.org/en-US/docs/Web/CSS/align-content
    * @default 'start'
    */
-  alignItems?: 'stretch' | ContentPosition;
+  alignContent?: 'stretch' | ContentPosition | ContentDistribution;
 
   /**
-   * Aligns the Stack along the cross axis.
+   * Aligns the Stack's children along the cross axis.
    *
-   * @see https://developer.mozilla.org/en-US/docs/Web/CSS/align-content
-   * @default 'start'
+   * @see https://developer.mozilla.org/en-US/docs/Web/CSS/align-items
+   * @default 'stretch'
    */
-  alignContent?: 'stretch' | ContentPosition | ContentDistribution;
+  alignItems?: 'stretch' | ContentPosition;
 
   /**
    * The vertical padding around the stack.
@@ -103,13 +104,11 @@ export interface StackProps extends PaddingProps, SizingProps, GapProps {
 
   /**
    * Whether the children should be stretched to fill the cross axis.
-   * @deprecated Has no effect.
    */
   flexChildren?: boolean;
 
   /**
-   * The flex value for the stack.
-   * @deprecated All stacks use flex 1. Use `blockSize` and `inlineSize` to customize the size of your stack.
+   * The flex value for the stack. Flex 1 will stretch the stack to fill the parent.
    */
   flex?: number;