Allow individual version managers to trigger manual Ruby selection #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
the
vscode
Graphite App
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
the
other
Graphite App
vinistock
force-pushed
the
11-06-allow_individual_version_managers_to_trigger_manual_ruby_selection
branch
from
b9e537c
to
ba965f8
Compare
vinistock
force-pushed
the
11-06-allow_individual_version_managers_to_trigger_manual_ruby_selection
branch
from
ba965f8
to
04bc155
Compare
vinistock
force-pushed
the
11-06-allow_individual_version_managers_to_trigger_manual_ruby_selection
branch
from
04bc155
to
e0025a6
Compare
andyw8
approved these changes
Nov 20, 2024
st0012
approved these changes
Nov 20, 2024
vinistock
deleted the
11-06-allow_individual_version_managers_to_trigger_manual_ruby_selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
First step for #2793
This PR passes down the
manuallySelectRubyfunction to version managers in order to allow specific version managers to offer configuring fallbacks under certain situations.Implementation
This PR only starts passing the function down to managers. The next PR in the stack starts using it.
Automated Tests
Updated existing tests.