Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add definition for all missing global variable nodes #2757

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Add definition for all missing global variable nodes #2757

merged 5 commits into from
Oct 23, 2024

Conversation

snutij
Copy link
Contributor

@snutij snutij commented Oct 22, 2024

Motivation

Should be the last part of #2644

Handle missing global variable nodes in definition requests (initially implemented here: #2673).

Implementation

  • Add listener for all global variable nodes
  • Search for entries in index with variable name
  • Push each entry location in response

Automated Tests

  • Added a test with assertions for each kind of global variable, and RBS definition.

Manual Tests

Kapture.2024-10-22.at.21.39.38.mp4

@snutij snutij requested a review from a team as a code owner October 22, 2024 19:42
@vinistock vinistock added enhancement New feature or request server This pull request should be included in the server gem's release notes labels Oct 22, 2024
vinistock
vinistock approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I just left a question regarding the hover test as I don't understand why it needs to change.

test/requests/hover_expectations_test.rb Show resolved Hide resolved
@vinistock vinistock merged commit 6803883 into Shopify:main Oct 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snutij @vinistock