Fix minitest spec code lens load path #2706
Merged
+212
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmarshall
force-pushed
the
fix-spec-code-lens
branch
from
c243daf
to
c12ef97
Compare
Some codebases (particularly those using minitest/spec) have tests in the `spec` directory instead of the `test` directory. This commit adds support for detecting these paths and adjusting the load path accordingly. I opted to not include any directory by default. If the path contains `test` or `spec`, the appropriate directory is added to the load path. If the path doesn't contain either, then it seems unlikely that the `test` directory should be added to the load path.
thomasmarshall
force-pushed
the
fix-spec-code-lens
branch
from
c12ef97
to
12f70f0
Compare
thomasmarshall
changed the title
vinistock
added
bugfix
Co-authored-by: Vinicius Stock <[email protected]>
|
Thanks, Thomas! |
|
Not essential, but it might be nice to show a warning if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2308 and #2688.
This PR changes the code lens base test command to add
specto the load path instead oftestif the current path is inside aspecdirectory (for example tapioca).Implementation
It checks to see whether the current path is inside a
specdirectory or atestdirectory and adds an appropriate-Iargument to the base command.This changes the default behavior—if the current path is in neither a
specortestdirectory it no longer adds-Itest. Is this reasonable behavior?There are of course weird edge cases here, for example if the path is inside both a
specandtestdirectory (liketest/spec/foo_test.rb). In that case bothtestandspecwould be added to the load path, but I don't currently see a better way of guessing which directory should be in the load path.Automated Tests
I added a new test case to capture the behavior for minitest spec code lens. I also regenerated the expectation JSON files, which have mostly changed just to remove
-Itest. We could change the logic so-Itestis added by default, even if it's not in atestdirectory, and only switch to-Ispecif necessary. That would minimize the expectation JSON changes here.Manual Tests
Use code lens to run specs in the tapioca codebase (upgrade to latest minitest first):
spec-code-lens.mov
Use code lens to make sure non-spec tests still work fine:
test-code-lens.mov