Display add-on version in the displayAddons command #2662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since add-ons now can specify their versions, we can also display them in VS Code.
Implementation
version
torubyLsp/workspace/addons
's responseversion
attribute to theAddon
extension class as older versions ofruby-lsp
don't return itversion
information todisplayAddon
command's output:Automated Tests
Updated an existing case for it.
Manual Tests
ruby-lsp-rails
as the development hostruby-lsp-rails
's Gemfile to use this branch ofruby-lsp
gem "ruby-lsp", github: "Shopify/ruby-lsp", branch: "display-add-on-version"
bundle update
Ruby LSP: Display addons
command in VS Code's command palette