Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display add-on version in the displayAddons command #2662

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Oct 3, 2024

Motivation

Since add-ons now can specify their versions, we can also display them in VS Code.

Implementation

  • Add version to rubyLsp/workspace/addons's response
  • Add a nullable version attribute to the Addon extension class as older versions of ruby-lsp don't return it
  • Add version information to displayAddon command's output:
Screenshot 2024-10-03 at 14 51 59

Automated Tests

Updated an existing case for it.

Manual Tests

  1. Run Ruby LSP extension with this branch
  2. Use the latest ruby-lsp-rails as the development host
  3. Update ruby-lsp-rails's Gemfile to use this branch of ruby-lsp
    • gem "ruby-lsp", github: "Shopify/ruby-lsp", branch: "display-add-on-version"
    • Run bundle update
  4. After Ruby LSP is initialized, run Ruby LSP: Display addons command in VS Code's command palette

@st0012 st0012 added enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes server This pull request should be included in the server gem's release notes labels Oct 3, 2024
@st0012 st0012 force-pushed the display-add-on-version branch from ecc7819 to c92c6fa Compare October 3, 2024 14:02
@st0012 st0012 marked this pull request as ready for review October 3, 2024 14:13
@st0012 st0012 requested a review from a team as a code owner October 3, 2024 14:13
@st0012 st0012 requested review from andyw8 and vinistock October 3, 2024 14:13
@st0012 st0012 merged commit 6b6dcf8 into main Oct 3, 2024
34 checks passed
@st0012 st0012 deleted the display-add-on-version branch October 3, 2024 14:32
@vinistock
Copy link
Member

This may be a bit premature. If add-ons haven't upgrade to the latest API yet, the moment the extension is released it's going to break. Why do we need to add this immediately? Can it wait a bit until people had the chance to upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants