Create RBSDocument #2437
Merged
Create RBSDocument #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
vinistock
force-pushed
the
vs-make-document-generic
branch
from
760779f to
d879724
Compare
andyw8
approved these changes
Aug 14, 2024
vinistock
force-pushed
the
vs-add-rbs-document
branch
from
ea412df to
d217d90
Compare
st0012
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Step towards #1206
Create an
RBSDocumentimplementation, so that we can start handling RBS files in the future and add features like document symbol, definition, hover, etc.Implementation
Created the new class and started handling it in the server too. That way, even if the VS Code extension is not registering for RBS files yet, we can have people update to versions of the language server that already handles it, which should reduce the surface area for synchronization issues between client and server.
Automated Tests
Added a test verifying the basics of the new class.