Filter instance variable owners before deduping #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed that I wasn't seeing as many instance variable completion candidates as I expected. The reason is because the order of operations were inverted.
Since we can have the same instance variable name exist multiple times, but belong to different owners, we need to first filter based on owner to find the ones that belong to the type we're searching for and then dedup the names to avoid showing duplicates.
If we do it the other way around, when we run
uniq!we may be discarding the instance variable entry that belongs to the owner we're searching for - and thus we find no matches.Implementation
Just switched the order.
Automated Tests
Added a test that demonstrates the bug.