Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add jruby to CI #1257

Closed
wants to merge 2 commits into from

Conversation

tachyons
Copy link

@tachyons tachyons commented Dec 17, 2023

Add JRuby and JRuby CI to expand the platform coverage.

Motivation

Implementation

Automated Tests

Manual Tests

Fixes #687

@tachyons tachyons requested a review from a team as a code owner December 17, 2023 10:42
@tachyons tachyons requested review from andyw8 and vinistock December 17, 2023 10:42
@tachyons tachyons marked this pull request as draft December 17, 2023 10:42
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is having platform issues. Not sure how you solve them exactly, is there a generic java platform that's not tied to a specific version?

@@ -35,7 +35,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
ruby: ["3.0", "3.1", "3.2", "head"]
ruby: ["3.0", "3.1", "3.2", "head", "jruby", "jruby-head"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just jruby-head is probably fine

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinistock I tried that too, But it was still failing with cryptic sorbet error. I haven't worked with sorbet before to debug that.

@tachyons
Copy link
Author

tachyons commented Dec 19, 2023

Screenshot 2023-12-19 at 7 40 08 AM

This is the error I am getting, Same issue is reported by another user here

Add JRuby and JRuby CI to expand the platform coverage.
@tachyons tachyons force-pushed the tachyons-add-jruby-head branch from 5f1c304 to 29347a2 Compare December 19, 2023 02:12
@andyw8
Copy link
Contributor

andyw8 commented Dec 19, 2023

Thank you, it seems this related to the patch we have for URI::Generic.from_path.

As Sorbet does not officially support JRuby, this may be a difficult one to solve...

@andyw8
Copy link
Contributor

andyw8 commented Dec 21, 2023

I'm going to close this for now until we address JRuby support in #1263. If we can find a way to support it, then we can add it to CI.

@andyw8 andyw8 closed this Dec 21, 2023
@andyw8 andyw8 mentioned this pull request Mar 13, 2024
@andyw8
Copy link
Contributor

andyw8 commented Jun 13, 2024

Re-opening this for tracking JRuby since #1263 was resolved.

@andyw8 andyw8 reopened this Jun 13, 2024
Copy link
Contributor

This pull request is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Aug 12, 2024
@github-actions github-actions bot removed the Stale label Aug 13, 2024
Copy link
Contributor

This pull request is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Oct 13, 2024
@github-actions github-actions bot closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI against JRuby head
4 participants