-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Add jruby to CI #1257
[Draft] Add jruby to CI #1257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI is having platform issues. Not sure how you solve them exactly, is there a generic java platform that's not tied to a specific version?
.github/workflows/ci.yml
Outdated
@@ -35,7 +35,7 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
os: [ubuntu-latest, macos-latest, windows-latest] | |||
ruby: ["3.0", "3.1", "3.2", "head"] | |||
ruby: ["3.0", "3.1", "3.2", "head", "jruby", "jruby-head"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just jruby-head
is probably fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinistock I tried that too, But it was still failing with cryptic sorbet error. I haven't worked with sorbet before to debug that.
9e513df
to
5f1c304
Compare
This is the error I am getting, Same issue is reported by another user here |
Add JRuby and JRuby CI to expand the platform coverage.
5f1c304
to
29347a2
Compare
Thank you, it seems this related to the patch we have for As Sorbet does not officially support JRuby, this may be a difficult one to solve... |
I'm going to close this for now until we address JRuby support in #1263. If we can find a way to support it, then we can add it to CI. |
Re-opening this for tracking JRuby since #1263 was resolved. |
This pull request is being marked as stale because there was no activity in the last 2 months |
This pull request is being marked as stale because there was no activity in the last 2 months |
Add JRuby and JRuby CI to expand the platform coverage.
Motivation
Implementation
Automated Tests
Manual Tests
Fixes #687