Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform client of server extensions #590

Closed
Tracked by #443 ...
vinistock opened this issue Mar 28, 2023 · 3 comments
Closed
Tracked by #443 ...

Inform client of server extensions #590

vinistock opened this issue Mar 28, 2023 · 3 comments
Labels
addons Tasks related to Ruby LSP addons enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale

Comments

@vinistock
Copy link
Member

vinistock commented Mar 28, 2023

Once any gem can register an extension with the Ruby LSP, it may not be super clear what's going on in the server. We should start giving more visibility into this by informing the client about which extensions are running in the server.

Stretch goal for this issue: allowing turning an extension off if it's causing trouble.

I believe the easiest way of doing this would be sending a custom notification to the client (something like ruby_lsp/extensions) during extension activation. Then the client can handle that notification and display which extensions are available in the status centre.

@vinistock vinistock added the enhancement New feature or request label Mar 28, 2023
@vinistock vinistock added this to the 2023-Q2 milestone Mar 28, 2023
@andyw8
Copy link
Contributor

andyw8 commented Apr 25, 2023

From talking with @vinistock:

We may also want to have a way to warn users if specific extensions are crashing (or causing performance problems).

@vinistock vinistock modified the milestones: 2023-Q2, 2023-Q3 Jul 10, 2023
@vinistock vinistock added the addons Tasks related to Ruby LSP addons label Jul 10, 2023
@vinistock vinistock self-assigned this Jul 11, 2023
@vinistock vinistock removed their assignment Jul 17, 2023
@vinistock
Copy link
Member Author

Putting this on pause until we have more use cases to learn from.

@vinistock vinistock added the pinned This issue or pull request is pinned and won't be marked as stale label Jul 20, 2023
@vinistock vinistock modified the milestones: 2023-Q3, 2023-Q4 Oct 25, 2023
@vinistock
Copy link
Member Author

This was already completed and the addons are now displayed in the language status item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Tasks related to Ruby LSP addons enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants