Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for changes to index enhancements API #529

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Update for changes to index enhancements API #529

merged 3 commits into from
Nov 21, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Nov 19, 2024 •
edited
Loading

For Shopify/ruby-lsp#2857

I also added an ActiveSupport concern to the sample app for manual verification/exploration.

@andyw8 andyw8 force-pushed the andyw8/update-enhancements-api branch 5 times, most recently from 6829767 to 0f39fa0 Compare November 19, 2024 20:18
andyw8
andyw8 commented Nov 19, 2024
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
@andyw8 andyw8 force-pushed the andyw8/update-enhancements-api branch from 0f39fa0 to 03bbd63 Compare November 19, 2024 20:24
@andyw8 andyw8 marked this pull request as ready for review November 19, 2024 20:24
@andyw8 andyw8 requested a review from a team as a code owner November 19, 2024 20:24
@andyw8
Copy link
Contributor Author

andyw8 commented Nov 19, 2024

(looks like some tests are failing for Rails main)

@andyw8 andyw8 mentioned this pull request Nov 19, 2024
Merged
@andyw8 andyw8 force-pushed the andyw8/update-enhancements-api branch from 03bbd63 to 1bbc5ce Compare November 21, 2024 12:54
@andyw8 andyw8 added chore Chore task enhancement New feature or request and removed chore Chore task labels Nov 21, 2024
@andyw8 andyw8 force-pushed the andyw8/update-enhancements-api branch from 1bbc5ce to d6c4f17 Compare November 21, 2024 12:56
vinistock
vinistock approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that the API changes greatly simplified the code 🎉

lib/ruby_lsp/ruby_lsp_rails/indexing_enhancement.rb Outdated Show resolved Hide resolved
test/dummy/app/models/concerns/verifiable.rb Outdated Show resolved Hide resolved
@vinistock vinistock mentioned this pull request Nov 21, 2024
Closed
@andyw8 andyw8 enabled auto-merge (squash) November 21, 2024 17:21
@andyw8 andyw8 merged commit cba97f8 into main Nov 21, 2024
28 checks passed
@andyw8 andyw8 deleted the andyw8/update-enhancements-api branch November 21, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock