Unify all error handling for the server #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
commented
Nov 18, 2024
Comment on lines
+2
to
+6
| "rubyLsp.indexing": { | ||
| "includedPatterns": [ | ||
| "test/dummy/**/*.rb" | ||
| ] | ||
| } |
There was a problem hiding this comment.
We need to ensure that the dummy files are indexed to be able to test our own features. A recent optimization in the LSP made us fully ignore the entire test directory straight away.
This was referenced Nov 20, 2024
vinistock
force-pushed
the
11-18-unify_all_error_handling_for_the_server
branch
from
e912ef3
to
8b98849
Compare
vinistock
force-pushed
the
11-18-unify_all_error_handling_for_the_server
branch
from
8b98849
to
342a2d5
Compare
KaanOzkan
approved these changes
Nov 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Shopify/ruby-lsp#2886
We cannot use blanket rescue statements for the entire server because the behaviour for handling errors is different between requests and notifications.
For requests, we want to return
error: messageinstead of the typicalyresult: something. And for notifications, we cannot return anything, we can only log that an error occurred.The approach that I took here is to create handlers that we can use both ourselves and in server add-ons, that provide appropriate error handling for requests or notifications.
I also created convenience methods for returning responses or errors.