test snapit

[robin-drexler]

No description provided.

[robin-drexler]

/snapit

[robin-drexler]

/snapit

[simontaisne]

/snapit

[simontaisne]

@robin-drexler snapit is running into E404 Not Found errors when trying to publish the remote-dom/core, @remote-dom/preact, and @remote-dom/signals packages to NPM. Do you think it might be because we're missing the NPM_TOKEN environment variable?

remote-dom/.github/workflows/snapit.yml

Lines 22 to 23 in d22c88e

	GITHUB_TOKEN: ${{ secrets.SHOPIFY_GH_ACCESS_TOKEN }}
	NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

[robin-drexler]

@robin-drexler snapit is running into E404 Not Found errors when trying to publish the remote-dom/core, @remote-dom/preact, and @remote-dom/signals packages to NPM. Do you think it might be because we're missing the NPM_TOKEN environment variable?

remote-dom/.github/workflows/snapit.yml

Lines 22 to 23 in d22c88e

	GITHUB_TOKEN: ${{ secrets.SHOPIFY_GH_ACCESS_TOKEN }}
	NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

yeah it doesn't work (yet)

We had to merge the action to actually try it.

I'm not sure yet why it's not working, but noticed the 404.

We do feed it a token: https://github.com/Shopify/remote-dom/blob/main/.github/workflows/snapit.yml#L23, but maybe it's not the correct one.
It's the same one we use in other places, but as NODE_AUTH_TOKEN.

github actions are unfortunately quite difficult to test.

[robin-drexler]

/snapit

[robin-drexler]

/snapit

[shopify-github-actions-access]

🫰✨ Thanks @robin-drexler! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@remote-dom/core": "0.0.0-snapshot-20241120193113",
"@remote-dom/preact": "0.0.0-snapshot-20241120193113",
"@remote-dom/signals": "0.0.0-snapshot-20241120193113"

[robin-drexler]

/snapit

[shopify-github-actions-access]

🫰✨ Thanks @robin-drexler! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@remote-dom/core": "0.0.0-snapshot-20241120201825",
"@remote-dom/polyfill": "0.0.0-snapshot-20241120201825",
"@remote-dom/preact": "0.0.0-snapshot-20241120201825",
"@remote-dom/react": "0.0.0-snapshot-20241120201825",
"@remote-dom/signals": "0.0.0-snapshot-20241120201825"

[simontaisne]

Nice!