fix(Window.setGlobal): window aliases should refer to globalThis #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all of the following must be true: window.window === window globalThis.window === globalThis globalThis.self === globalThis.window
This comment has been minimized.
This comment has been minimized.
| [ONCE_LISTENERS]?: WeakMap<EventListenerOrEventListenerObject, EventListener>; | ||
| [LISTENERS]: | ||
| | Map<string, Set<EventListenerOrEventListenerObject>> | ||
| | undefined = undefined; |
There was a problem hiding this comment.
Needed to set these to undefined so undefined is copied over in setGlobal
There was a problem hiding this comment.
These could just be set to maps, but I assumed that was being avoided for performance reasons?
vividviolet
approved these changes
Oct 28, 2024
Merged
This was referenced Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures all of the following are true after calling
Window.setGlobal(window):