Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call hook when creating text #436

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Call hook when creating text #436

merged 2 commits into from
Sep 3, 2024

Conversation

jakearchibald
Copy link
Contributor

This was simply missing.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
lemonmade
lemonmade approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@lemonmade lemonmade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jake! Can you also add a changeset by running pnpm changeset from the root of the repo?

@jakearchibald
Copy link
Contributor Author

ugh yeah, my bad

@lemonmade lemonmade merged commit 5979797 into main Sep 3, 2024
5 checks passed
@lemonmade lemonmade deleted the ja/fix-create-text-hook branch September 3, 2024 13:18
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemonmade lemonmade lemonmade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakearchibald @lemonmade