Fixes to event dispatching #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Respect stopPropagation throughout both capturing and bubbling - Call listeners on the target element in both the capturing and bubbling phases - Simplify returning defaultPrevented
jakearchibald
force-pushed
the
ja/polyfill-event-fixes
branch
from
c75c75d to
36f8507
Compare
|
Thanks Jake! |
lemonmade
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Make immediatePropogationStopped private-ish * Use workspace polyfill * Stopping immediate propagation also stops regular propagation * Assorted dispatching fixes - Respect stopPropagation throughout both capturing and bubbling - Call listeners on the target element in both the capturing and bubbling phases - Simplify returning defaultPrevented * Add changeset * Better param name * Fix lockfile * Trying again…
lemonmade
added a commit
that referenced
this pull request
Aug 14, 2024
Add `getAttributeNames()` polyfill to support vitest assertions Add event listener support Add proper support for event listeners Clean up some naming Update READMEs Fix Preact tests More documentation More documentation polish Add missing generic argument More docs polish Fix `Event.bubbles` and `Event.composedPath()` implementations Fix missing `connectedCallback()` and `disconnectedCallback)` calls Added `bubbles` configuration option for `RemoteElement` events Fixes to event dispatching (#403) * Make immediatePropogationStopped private-ish * Use workspace polyfill * Stopping immediate propagation also stops regular propagation * Assorted dispatching fixes - Respect stopPropagation throughout both capturing and bubbling - Call listeners on the target element in both the capturing and bubbling phases - Simplify returning defaultPrevented * Add changeset * Better param name * Fix lockfile * Trying again… Revert pnpm fixes This reverts part of commit 0ce1450. Minimal change to pnpm lockfile
lemonmade
added a commit
that referenced
this pull request
Aug 14, 2024
Add `getAttributeNames()` polyfill to support vitest assertions Add event listener support Add proper support for event listeners Clean up some naming Update READMEs Fix Preact tests More documentation More documentation polish Add missing generic argument More docs polish Fix `Event.bubbles` and `Event.composedPath()` implementations Fix missing `connectedCallback()` and `disconnectedCallback)` calls Added `bubbles` configuration option for `RemoteElement` events Fixes to event dispatching (#403) * Make immediatePropogationStopped private-ish * Use workspace polyfill * Stopping immediate propagation also stops regular propagation * Assorted dispatching fixes - Respect stopPropagation throughout both capturing and bubbling - Call listeners on the target element in both the capturing and bubbling phases - Simplify returning defaultPrevented * Add changeset * Better param name * Fix lockfile * Trying again… Revert pnpm fixes This reverts part of commit 0ce1450. Minimal change to pnpm lockfile
lemonmade
added a commit
that referenced
this pull request
Aug 22, 2024
Add `getAttributeNames()` polyfill to support vitest assertions Add event listener support Add proper support for event listeners Clean up some naming Update READMEs Fix Preact tests More documentation More documentation polish Add missing generic argument More docs polish Fix `Event.bubbles` and `Event.composedPath()` implementations Fix missing `connectedCallback()` and `disconnectedCallback)` calls Added `bubbles` configuration option for `RemoteElement` events Fixes to event dispatching (#403) * Make immediatePropogationStopped private-ish * Use workspace polyfill * Stopping immediate propagation also stops regular propagation * Assorted dispatching fixes - Respect stopPropagation throughout both capturing and bubbling - Call listeners on the target element in both the capturing and bubbling phases - Simplify returning defaultPrevented * Add changeset * Better param name * Fix lockfile * Trying again… Revert pnpm fixes This reverts part of commit 0ce1450. Minimal change to pnpm lockfile
lemonmade
added a commit
that referenced
this pull request
Aug 27, 2024
* Support for remote attributes and event listeners Add `getAttributeNames()` polyfill to support vitest assertions Add event listener support Add proper support for event listeners Clean up some naming Update READMEs Fix Preact tests More documentation More documentation polish Add missing generic argument More docs polish Fix `Event.bubbles` and `Event.composedPath()` implementations Fix missing `connectedCallback()` and `disconnectedCallback)` calls Added `bubbles` configuration option for `RemoteElement` events Fixes to event dispatching (#403) * Make immediatePropogationStopped private-ish * Use workspace polyfill * Stopping immediate propagation also stops regular propagation * Assorted dispatching fixes - Respect stopPropagation throughout both capturing and bubbling - Call listeners on the target element in both the capturing and bubbling phases - Simplify returning defaultPrevented * Add changeset * Better param name * Fix lockfile * Trying again… Revert pnpm fixes This reverts part of commit 0ce1450. Minimal change to pnpm lockfile * Update .changeset/slimy-lizards-tickle.md Co-authored-by: Jake Archibald <[email protected]> * Only send AT_TARGET events to the remote environment * Add more APIs for handling React/ Preact host handling of event listeners * Add support for event properties * Use weakmaps for storing private implementation details * Export attribute and event listener updater --------- Co-authored-by: Jake Archibald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.