Merge pull request #255 from Shopify/rd/file-support

Allow `File` (and other object types) to be send over RPC
Shopify · Feb 12, 2024 · 9037436 · 9037436
2 parents 42cbc05 + c89ffb7
commit 9037436
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/.changeset/many-masks-behave.md b/.changeset/many-masks-behave.md
@@ -0,0 +1,5 @@
+---
+'@remote-ui/rpc': patch
+---
+
+allow File and other object types to be send over the RPC layer
diff --git a/packages/rpc/src/encoding/basic.ts b/packages/rpc/src/encoding/basic.ts
@@ -144,10 +144,6 @@ export function createBasicEncoder(api: EncodingStrategyApi): EncodingStrategy {
         return value as any;
       }
 
-      if (value instanceof ArrayBuffer) {
-        return value;
-      }
-
       if (Array.isArray(value)) {
         return value.map((value) => decode(value, retainedBy));
       }
@@ -209,13 +205,15 @@ export function createBasicEncoder(api: EncodingStrategyApi): EncodingStrategy {
         return proxy as any;
       }
 
-      return Object.keys(value).reduce(
-        (object, key) => ({
-          ...object,
-          [key]: decode((value as any)[key], retainedBy),
-        }),
-        {},
-      ) as any;
+      if (isBasicObject(value)) {
+        return Object.keys(value).reduce(
+          (object, key) => ({
+            ...object,
+            [key]: decode((value as any)[key], retainedBy),
+          }),
+          {},
+        ) as any;
+      }
     }
 
     return value as any;