Fix missing attributes and event listeners on root receiver elements

Shopify · Dec 4, 2024 · 807db10 · 807db10
1 parent c917461
commit 807db10
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/.changeset/wet-mirrors-bathe.md b/.changeset/wet-mirrors-bathe.md
@@ -0,0 +1,6 @@
+---
+'@remote-dom/signals': patch
+'@remote-dom/core': patch
+---
+
+Fix missing attributes and event listeners on root receiver elements
diff --git a/packages/core/source/receivers/RemoteReceiver.ts b/packages/core/source/receivers/RemoteReceiver.ts
@@ -61,6 +61,10 @@ export interface RemoteReceiverRoot {
   readonly type: typeof NODE_TYPE_ROOT;
   readonly children: readonly RemoteReceiverNode[];
   readonly properties: NonNullable<RemoteElementSerialization['properties']>;
+  readonly attributes: NonNullable<RemoteElementSerialization['attributes']>;
+  readonly eventListeners: NonNullable<
+    RemoteElementSerialization['eventListeners']
+  >;
   readonly version: number;
 }
 
@@ -102,6 +106,8 @@ export class RemoteReceiver {
     children: [],
     version: 0,
     properties: {},
+    attributes: {},
+    eventListeners: {},
   };
 
   /**

diff --git a/packages/signals/source/SignalRemoteReceiver.ts b/packages/signals/source/SignalRemoteReceiver.ts
@@ -72,6 +72,12 @@ export interface SignalRemoteReceiverRoot {
   readonly properties: ReadonlySignal<
     NonNullable<RemoteElementSerialization['properties']>
   >;
+  readonly attributes: ReadonlySignal<
+    NonNullable<RemoteElementSerialization['attributes']>
+  >;
+  readonly eventListeners: ReadonlySignal<
+    NonNullable<RemoteElementSerialization['eventListeners']>
+  >;
   readonly children: ReadonlySignal<readonly SignalRemoteReceiverNode[]>;
 }
 
@@ -111,6 +117,8 @@ export class SignalRemoteReceiver {
     id: ROOT_ID,
     type: NODE_TYPE_ROOT,
     properties: signal({}),
+    attributes: signal({}),
+    eventListeners: signal({}),
     children: signal([]),
   };