Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notices, migration guide and existing queries. #987

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

scottdixon
Copy link
Contributor

@scottdixon scottdixon commented Aug 13, 2024

image
  • Adds deprecation notice to readme:
image

@scottdixon scottdixon requested a review from abecciu August 26, 2024 00:46
@johndwells
Copy link

Can I ask, is this the direction this library is taking, is it actually being deprecated?

Because we've also found this branch: sd-cart, which migrates to use the new Cart API. We've been testing this branch and have found it works well, though we did submit a pull request last week that adds some missing info about the underlying product of a line item.

So which is it, is this library being abandoned, or can we expect it to continue to be maintained and kept up to date with the latest API changes?

We love this library and really hope it sticks around!

@macpham macpham self-requested a review October 1, 2024 22:29
@thipokch
Copy link

thipokch commented Oct 4, 2024

I just started using this library and was caught off guard by the lack of a deprecation notice, which I ended up wasting a lot of time. The value proposition by Storefront API Client is pretty minimal, it's basically a graphql client. Please help me understand the context or why this decision was made by Shopify, thank you.

@johndwells Do you think it might be worth considering a community-maintained fork?

@johndwells
Copy link

@thipokch It would be a shame to see this library lose 1st party support. I wish we could commit resources to lead the community in maintaining this, but we'd be overstretching ourselves, and besides there is a lot of tooling in this repo that I'm not familiar with.

For ourselves, we've already abandoned the library all-together, and re-wrote our own JS to speak directly to the Storefront API. If the community does rally to save the library, we'd happy return and contribute if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants