Skip to content

Commit

Permalink
Drop Ruby 2.4 support
Browse files Browse the repository at this point in the history
  • Loading branch information
swalkinshaw committed Apr 5, 2024
1 parent 8afcdbb commit f4d4f34
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 17 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ jobs:
matrix:
ruby: [2.7, 3.0, 3.1, 3.2, 3.3]
graphql_version: ['~> 1.12.18', '~> 1.13', '~> 2.0']
include:
- ruby: 2.4
graphql_version: '~> 1.12.18'
- ruby: 2.4
graphql_version: '~> 1.13'
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
Expand Down
6 changes: 2 additions & 4 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,5 @@ source 'https://rubygems.org'
gemspec

gem 'graphql', ENV['GRAPHQL_VERSION'] if ENV['GRAPHQL_VERSION']
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4.0')
gem 'rubocop', '~> 1.61.0', require: false
gem "rubocop-shopify", '~> 1.0.7', require: false
end
gem 'rubocop', '~> 1.61.0', require: false
gem "rubocop-shopify", '~> 1.0.7', require: false
12 changes: 5 additions & 7 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,9 @@ end

task(default: :test)

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4.0')
task :rubocop do
require 'rubocop/rake_task'
RuboCop::RakeTask.new
end

task(default: :rubocop)
task :rubocop do
require 'rubocop/rake_task'
RuboCop::RakeTask.new
end

task(default: :rubocop)
2 changes: 1 addition & 1 deletion graphql-batch.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
spec.homepage = "https://github.com/Shopify/graphql-batch"
spec.license = "MIT"

spec.required_ruby_version = ">= 2.4"
spec.required_ruby_version = ">= 2.7"

spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
spec.bindir = "exe"
Expand Down

0 comments on commit f4d4f34

Please sign in to comment.