Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Use yarn resolutions to fix typescript errors in newly scaffolded checkout ui extension #395

Closed
rhyek opened this issue Aug 31, 2022 · 1 comment · Fixed by #579
Assignees
Labels
Type: Bug Something isn't working Type: Enhancement New feature or request

Comments

@rhyek
Copy link

rhyek commented Aug 31, 2022

What area(s) will this request affect?

Extension

What type of change do you want to see?

New feature

Overview

When scaffolding a new extension I get the TypeScript errors mentioned in Shopify/remote-dom#153 (in VSCode, not with yarn dev).
The solution proposed in that issue is to add this to the package.json and yarn install:

{
  ...
  "resolutions": {
    "@types/react": "17.0.30"
  }
}

Motivation

Should not have TypeScript errors in newly created extension project.

@rhyek rhyek added the Type: Enhancement New feature or request label Aug 31, 2022
@jamesvidler
Copy link
Contributor

Related to this issue is: Shopify/shopify-cli-extensions#315. We attempted to put in a fix for this in CLI 2.

One additional note to consider is that resolutions are only for yarn. I think we would need to conditionally use resolutions if the package manager is yarn, or overrides if the package manager is npm or pnpm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment