Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Select Default Poster/Fanart/Banner. #678

Merged

Conversation

ElementalCrisis
Copy link
Member

@ElementalCrisis ElementalCrisis commented Nov 14, 2023

While you can select a default fanart and it does update, we currently have it set to show a random fanart within a series. We will need to add logic for enabling/disabling random fanart/poster and fix this in the future.

I also fixed a key issue in series tags.

Copy link
Member

@revam revam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. I'll leave the rest to @hidden4003 and @ElementalCrisis to decide what to do with.

src/core/rtkQuery/splitV3Api/seriesApi.ts Outdated Show resolved Hide resolved
src/core/rtkQuery/splitV3Api/seriesApi.ts Show resolved Hide resolved
src/pages/collection/series/SeriesImages.tsx Outdated Show resolved Hide resolved
src/pages/collection/series/SeriesImages.tsx Outdated Show resolved Hide resolved
@hidden4003 hidden4003 merged commit d3b6763 into ShokoAnime:master Nov 16, 2023
3 checks passed
@ElementalCrisis ElementalCrisis deleted the series-change-default-image branch December 26, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants