Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint rules #644

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Add eslint rules #644

merged 4 commits into from
Sep 21, 2023

Conversation

hidden4003
Copy link
Member

No description provided.

@hidden4003 hidden4003 marked this pull request as ready for review September 21, 2023 15:11
@@ -37,20 +38,6 @@ export function mergeDeep(...objects) {
}, {});
}

// Needed to compare layout properties.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it is no longer in use

const tagAName = tags.data?.find(tag => tag.ID === tagA)?.Name;
const tagBName = tags.data?.find(tag => tag.ID === tagB)?.Name;
if (tagAName === undefined || tagBName === undefined) return 0;
return tagAName?.localeCompare(tagBName);
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I broke this or not

Copy link
Member

@harshithmohan harshithmohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidden4003 hidden4003 merged commit 85804e0 into master Sep 21, 2023
3 checks passed
@hidden4003 hidden4003 deleted the eslint-rules branch September 22, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants