Merge pull request cert-manager#97 from davidcollom/logging-fix

Fix Logging issue where %s is presented
SgtCoDFish · Sep 19, 2024 · a67ecbe · a67ecbe
2 parents 62bdc0e + 5fcfc47
commit a67ecbe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/controller/controller.go b/internal/controller/controller.go
@@ -54,12 +54,12 @@ func shouldSync(log logr.Logger, route *routev1.Route) bool {
 	}
 
 	if metav1.HasAnnotation(route.ObjectMeta, cmapi.IssuerNameAnnotationKey) {
-		log.V(5).Info("Route has the annotation %s=%s", cmapi.IssuerNameAnnotationKey, route.Annotations[cmapi.IssuerNameAnnotationKey])
+		log.V(5).Info("Route has the annotation", "annotation-key", cmapi.IssuerNameAnnotationKey, "annotation-value", route.Annotations[cmapi.IssuerNameAnnotationKey])
 		return true
 	}
 
 	if metav1.HasAnnotation(route.ObjectMeta, cmapi.IngressIssuerNameAnnotationKey) {
-		log.V(5).Info("Route has the annotation %s=%s", cmapi.IngressIssuerNameAnnotationKey, route.Annotations[cmapi.IngressIssuerNameAnnotationKey])
+		log.V(5).Info("Route has the annotation", "annotation-key", cmapi.IngressIssuerNameAnnotationKey, "annotation-value", route.Annotations[cmapi.IngressIssuerNameAnnotationKey])
 		return true
 	}
 

diff --git a/internal/controller/sync.go b/internal/controller/sync.go
@@ -107,7 +107,7 @@ func (r *Route) sync(ctx context.Context, req reconcile.Request, route *routev1.
 		if err != nil {
 			return result, err
 		}
-		r.eventRecorder.Event(route, corev1.EventTypeNormal, ReasonIssuing, "Created new CertificateRequest for Route %s")
+		r.eventRecorder.Event(route, corev1.EventTypeNormal, ReasonIssuing, "Created new CertificateRequest")
 		return result, nil
 	}
 	// is the CR Ready and Approved?