CORE: fix n deps overflow in pipelined schedule

Sergei-Lebedev · Dec 3, 2024 · 82565c3 · 82565c3
1 parent 7f3c2f6
commit 82565c3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/schedule/ucc_schedule.h b/src/schedule/ucc_schedule.h
@@ -107,9 +107,9 @@ typedef struct ucc_coll_task {
         /* used for lf mt progress queue */
         ucc_lf_queue_elem_t            lf_elem;
     };
-    uint8_t                            n_deps;
-    uint8_t                            n_deps_satisfied;
-    uint8_t                            n_deps_base;
+    uint32_t                           n_deps;
+    uint32_t                           n_deps_satisfied;
+    uint32_t                           n_deps_base;
     /* timestamp of the start time: either post or triggered_post */
     double                             start_time;
     uint32_t                           seq_num;

diff --git a/src/schedule/ucc_schedule_pipelined.c b/src/schedule/ucc_schedule_pipelined.c
@@ -256,7 +256,8 @@ ucc_status_t ucc_dependency_handler(ucc_coll_task_t *parent,
     ucc_status_t status;
     uint8_t      n_deps_satisfied;
 
-    n_deps_satisfied = ucc_atomic_fadd8(&task->n_deps_satisfied, 1);
+    n_deps_satisfied = ucc_atomic_fadd32(&task->n_deps_satisfied, 1);
+    ucc_assert(task->n_deps_satisfied > n_deps_satisfied);
 
     ucc_trace_req("task %p, n_deps %d, satisfied %d", task, task->n_deps,
                   n_deps_satisfied);