-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py]: move python code to test_locators.py
#2102
base: trunk
Are you sure you want to change the base?
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI Navin,
Thank you for the PR. Could you please look into comments provided.
Thanks,
Sri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't place HTML code here. Instead, you can use the static pages deployed on the official Selenium website
https://www.selenium.dev/selenium/web/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't find a similar html page, so created a PR to add it in selenium - SeleniumHQ/selenium#14905
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Moved python code of locators to
test_locators.py
andTypes of changes
Checklist
PR Type
Tests, Enhancement
Description
test_locators.py
with comprehensive test cases for all Selenium locator typesChanges walkthrough 📝
locators.html
Add HTML test page for locator examples
examples/python/tests/elements/locators.html
test_locators.py
Add comprehensive locator tests in Python
examples/python/tests/elements/test_locators.py
conftest.py
Add HTTP server fixture for serving test files
examples/python/tests/conftest.py
locators.*.md
Update documentation to reference new Python test examples
website_and_docs/content/documentation/webdriver/elements/locators.*.md
zh-cn)