[py] remove xfail attr for firefox and safari for cookie tests #14794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Removes
@pytest.mark.xfail_safari
and@pytest.mark.xfail_firefox
attribute for python cookie testsMotivation and Context
As per the docs and tested locally the attribute is no longer needed and can be tested with Safari and FireFox
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
@pytest.mark.xfail_firefox
and@pytest.mark.xfail_safari
decorators from cookie tests, allowing them to run on Firefox and Safari without expected failures.sameSite
cookie attribute is now supported in these browsers, aligning with local testing results.Changes walkthrough 📝
cookie_tests.py
Remove xfail markers for Firefox and Safari in cookie tests
py/test/selenium/webdriver/common/cookie_tests.py
@pytest.mark.xfail_firefox
decorator from tests.@pytest.mark.xfail_safari
decorator from tests.