[rb] unfail some code

SeleniumHQ · May 1, 2024 · dabf659 · dabf659
1 parent e521035
commit dabf659
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 45 deletions.
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml
@@ -62,49 +62,44 @@ jobs:
   #       --test_size_filters small
   #       //rb/spec/...
 
-  # integration-tests-local:
-  #   name: Local Tests
-  #   needs: build
-  #   uses: ./.github/workflows/bazel.yml
-  #   strategy:
-  #     fail-fast: false
-  #     matrix:
-  #       browser:
-  #         - chrome
-  #         - edge
-  #         - firefox
-  #         - safari
-  #       os:
-  #         - ubuntu
-  #         - windows
-  #         - macos
-  #       exclude:
-  #         - browser: edge
-  #           os: ubuntu
-  #         - browser: edge
-  #           os: macos
-  #         - browser: safari
-  #           os: ubuntu
-  #         - browser: safari
-  #           os: windows
-  #         # TODO: Investigate why they are timing out
-  #         - browser: chrome
-  #           os: windows
-  #         - browser: edge
-  #           os: windows
-  #   with:
-  #     name: Local Tests (${{ matrix.browser }}, ${{ matrix.os }})
-  #     browser: ${{ matrix.browser }}
-  #     cache-key: rb-${{ matrix.browser }}-test
-  #     os: ${{ matrix.os }}
-  #     run: >
-  #       bazel test
-  #       --build_tests_only
-  #       --flaky_test_attempts 3
-  #       --local_test_jobs 1
-  #       --test_size_filters large
-  #       --test_tag_filters ${{ matrix.browser }}
-  #       //rb/spec/...
+  integration-tests-local:
+    name: Local Tests
+    needs: build
+    uses: ./.github/workflows/bazel.yml
+    strategy:
+      fail-fast: false
+      matrix:
+        browser:
+          - chrome
+          - edge
+          # - firefox
+          # - safari
+        os:
+          # - ubuntu
+          - windows
+          # - macos
+        exclude:
+          - browser: edge
+            os: ubuntu
+          - browser: edge
+            os: macos
+          - browser: safari
+            os: ubuntu
+          - browser: safari
+            os: windows
+    with:
+      name: Local Tests (${{ matrix.browser }}, ${{ matrix.os }})
+      browser: ${{ matrix.browser }}
+      cache-key: rb-${{ matrix.browser }}-test
+      os: ${{ matrix.os }}
+      run: >
+        bazel test
+        --build_tests_only
+        --flaky_test_attempts 3
+        --local_test_jobs 1
+        --test_size_filters large
+        --test_tag_filters ${{ matrix.browser }}
+        //rb/spec/...
 
   integration-tests-remote:
     name: Remote Tests

diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
@@ -250,15 +250,13 @@ def safari_preview_driver(**opts)
         def chrome_options(args: [], **opts)
           opts[:binary] ||= ENV['CHROME_BINARY'] if ENV.key?('CHROME_BINARY')
           args << '--headless=chrome' if ENV['HEADLESS']
-          args << '--no-sandbox'
           args << '--disable-gpu'
           WebDriver::Options.chrome(browser_version: 'stable', args: args, **opts)
         end
 
         def edge_options(args: [], **opts)
           opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY')
           args << '--headless=chrome' if ENV['HEADLESS']
-          args << '--no-sandbox'
           args << '--disable-gpu'
           WebDriver::Options.edge(browser_version: 'stable', args: args, **opts)
         end