-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Generate list environment variables README automatically #2564
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
CI Failure Feedback 🧐(Checks updated until commit 7b687c2)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Checkout full list of environment variables here.
How to update or contribute to list of environment variables? Follow below steps:
Refresh the list to pick up new environment variables or default value
The script can be updated in scripts/generate_list_env_vars/extract_env.py.
Update the description for each environment variable in the file scripts/generate_list_env_vars/description.yaml.
Run the command in step (1) one more time to update the list of environment variables with new descriptions.
Motivation and Context
Types of changes
Checklist
PR Type
Documentation, Enhancement
Description
Added a script to extract and document environment variables.
Generated
ENV_VARIABLES.md
with a comprehensive list of environment variables.Updated
README.md
to include a link to the environment variables documentation.Enhanced the build process with a new Makefile target for updating environment variables.
Changes walkthrough 📝
bootstrap.sh
Use `requirements.txt` for Python dependencies
tests/charts/bootstrap.sh
requirements.txt
.extract_env.py
Script to extract and document environment variables
scripts/generate_list_env_vars/extract_env.py
Dockerfiles.
Makefile
Add Makefile target for environment variable updates
Makefile
update_list_env_vars
for generating environmentvariable documentation.
ENV_VARIABLES.md
Generated markdown for environment variables
ENV_VARIABLES.md
options.
README.md
Link to environment variables documentation in README
README.md
description.yaml
YAML file for environment variable descriptions
scripts/generate_list_env_vars/description.yaml
value.yaml
YAML file for environment variable default values
scripts/generate_list_env_vars/value.yaml
requirements.txt
Update test requirements with `pyyaml`
tests/requirements.txt
pyyaml
as a dependency for the new script.