Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pT5 rz chi2 cut definition into helix approximation (rebase PR40) #128

Open
wants to merge 1 commit into
base: CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch1_devel_rebased
Choose a base branch
from

Conversation

ariostas
Copy link
Member

This is a rebase of PR #40. Since it changes the performance I made it as its own PR so that we can compare the plots with the original PR.

@ariostas ariostas requested a review from YonsiG November 20, 2024 16:52
@ariostas ariostas changed the title Rebase PR40 Change pT5 rz chi2 cut definition into helix approximation (rebase PR40) Nov 22, 2024
@ariostas
Copy link
Member Author

/run all

Copy link

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     40.9    384.6    191.2    127.0    135.1    501.4    117.8    243.5    102.0      3.2    1846.5    1304.2+/- 362.3     491.8   explicit[s=4] (target branch)
   avg     40.5    383.9    191.0    128.8    136.8    499.8    106.6    244.6    101.9      2.8    1836.7    1296.4+/- 358.2     488.5   explicit[s=4] (this PR)

Copy link

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant