Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Occupancy Branches Back #404

Merged
merged 3 commits into from
May 29, 2024
Merged

Add Occupancy Branches Back #404

merged 3 commits into from
May 29, 2024

Conversation

GNiendorf
Copy link
Member

@GNiendorf GNiendorf commented May 21, 2024

Removed in #212, adding them back so that I can tune the occupancies for the low pT threshold. Keeping this as a draft PR since it seems like some branches are broken and this needs more cleanup.

@GNiendorf GNiendorf marked this pull request as ready for review May 21, 2024 19:51
@GNiendorf
Copy link
Member Author

/run standalone
/run CMSSW

Copy link

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     43.5    325.9    121.8     46.1     96.4    546.4    133.6    157.2    107.4      2.3    1580.5     990.6+/- 262.4     427.4   explicit_cache[s=4] (master)
   avg     44.5    326.4    122.4     48.6     95.9    548.5    133.3    156.3    107.0      2.7    1585.6     992.6+/- 263.2     432.3   explicit_cache[s=4] (this PR)

Copy link

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@GNiendorf
Copy link
Member Author

@VourMa This PR should be good to go.

@GNiendorf
Copy link
Member Author

/run standalone

Copy link

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     43.7    324.2    122.5     48.1     96.2    501.8    133.8    157.9    102.0      1.8    1532.1     986.6+/- 261.1     418.8   explicit_cache[s=4] (master)
   avg     45.2    326.6    124.8     50.0     96.8    505.4    135.9    158.9    100.2      3.8    1547.6     997.1+/- 263.5     422.1   explicit_cache[s=4] (this PR)

@VourMa VourMa merged commit 50fb47e into master May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants