[EdgeDB] Add PeriodicReport queries | refactor service/repo layers appropriately
#3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanjnelson
force-pushed
the
0933-periodic-report-queries
branch
2 times, most recently
from
1d3efe9
to
07d8f1b
Compare
bryanjnelson
commented
Jul 3, 2024
src/components/periodic-report/periodic-report.edgedb.repository.ts
Outdated
Show resolved
Hide resolved
bryanjnelson
force-pushed
the
0933-periodic-report-queries
branch
from
07d8f1b
to
d24f41f
Compare
bryanjnelson
force-pushed
the
0933-periodic-report-queries
branch
from
d24f41f
to
5b844a6
Compare
bryanjnelson
force-pushed
the
0933-periodic-report-queries
branch
from
5b844a6
to
ec52210
Compare
bryanjnelson
commented
Aug 8, 2024
| ), | ||
| })); | ||
|
|
||
| const query = e.select(report, this.hydrate); |
There was a problem hiding this comment.
@CarsonF - There is an error on the return type here. The EdgeDB and Neo4j versions don't match. I thought that if I hydrated here it would fix that, but I'm getting this error I don't understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday task
Description
Add
PeriodicReportqueries & refactor service/repo layers appropriatelyReady for review checklist