Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#282 Add Search Bar in Example Gallery App #293

Merged
merged 4 commits into from
Apr 2, 2024
Merged

#282 Add Search Bar in Example Gallery App #293

merged 4 commits into from
Apr 2, 2024

Conversation

vkmaxcooldude
Copy link
Contributor

Description

  • Create a BLoC, HomeBloc, for state management
  • Rewrite the Gallery screen, to integrate HomeBloc
  • Update the JSON, to store a list of ListTiles

Related Issues

Closes #282

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@vkmaxcooldude
Copy link
Contributor Author

@divyanshub024 Requesting review

@divyanshub024 divyanshub024 added this to the v0.8 milestone Mar 26, 2024
@vkmaxcooldude
Copy link
Contributor Author

@divyanshub024 Can you check?

divyanshub024
divyanshub024 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@divyanshub024 divyanshub024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vkmaxcooldude for back to back contributions 💯

@divyanshub024 divyanshub024 merged commit a8255db into Securrency-OSS:dev Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshub024 divyanshub024 divyanshub024 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

feat: Add a search bar in Mirai Gallery
3 participants
@vkmaxcooldude @divyanshub024 @Chennailions