Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Slash Commands and Context Menu Commands #109

Merged
merged 19 commits into from
Oct 30, 2024
Merged

Feature: Slash Commands and Context Menu Commands #109

merged 19 commits into from
Oct 30, 2024

Conversation

HunteRoi
Copy link
Member

@HunteRoi HunteRoi commented Oct 24, 2024 •
edited
Loading

Objective

Rework the command handling system to get rid of prefixes and archaic way of finding commands and arguments.

Side-effects

  • Rework of all commands behaviour for consistency
  • Event handling system also got updated for consistency
  • Fix for small warnings and errors (docker, db migrations, etc.)
  • Linter moved from eslint to biomejs
  • Fix an misconception where docker would never write to the bot_logs volume

Fixes #108, closes #94

@HunteRoi HunteRoi requested a review from DrakeXorn October 24, 2024 15:38
@HunteRoi HunteRoi self-assigned this Oct 24, 2024
@HunteRoi HunteRoi linked an issue Oct 24, 2024 that may be closed by this pull request
Args not recognized when space is not the delimiter #108
Closed
Tinaël Devresse added 3 commits October 24, 2024 22:47
feat(commands): move all commands to slash commands
ebc40dd 
Parallel to a huge refactor for the reply to interactions, all commands are now processed as slash commands (except for the pin command which became a message context menu command now). This means we do not need messageCreate event anymore (nor do we need the intents related to content).
Changes on the config to remove unnecessary emotes as well.
fix(db): migrations always run into error when run on existing db
82f91da
refactor(events): apply same strategy of loading commands to events
bbe6474 
Adapt helper to log information as well.
Fix dockerfile warning with stage names
@HunteRoi HunteRoi marked this pull request as ready for review October 24, 2024 21:24
HunteRoi
HunteRoi commented Oct 25, 2024
View reviewed changes
Copy link
Member Author

@HunteRoi HunteRoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

src/commands/owner/eval.ts Outdated Show resolved Hide resolved
src/commands/owner/reload.ts Outdated Show resolved Hide resolved
src/commands/owner/restart.ts Outdated Show resolved Hide resolved
src/models/Event.ts Outdated Show resolved Hide resolved
src/services/CommandHandler.ts Outdated Show resolved Hide resolved
@HunteRoi HunteRoi changed the title refactor(messageCreate): move commands handling into specific file Feature: Slash Commands and Context Menu Commands Oct 25, 2024
@HunteRoi HunteRoi added enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 28, 2024
DrakeXorn
DrakeXorn reviewed Oct 29, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
scripts/deploy-commands.cjs Outdated Show resolved Hide resolved
src/commands/others/pin.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@HunteRoi HunteRoi requested a review from DrakeXorn October 29, 2024 23:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

DrakeXorn
DrakeXorn approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@DrakeXorn DrakeXorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now it’s ready :^)

@HunteRoi HunteRoi merged commit efe18fd into master Oct 30, 2024
2 checks passed
@HunteRoi HunteRoi deleted the 108-args-not-recognized-when-space-is-not-the-delimiter branch October 30, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrakeXorn DrakeXorn DrakeXorn approved these changes

Assignees

@HunteRoi HunteRoi

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@HunteRoi @DrakeXorn