Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add debug dialog #144

Merged

Conversation

lennartkloock
Copy link
Member

Proposed changes

Adds debug dialog.
Toggle with Ctrl+Alt+Shift+D.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

New Dev Banner

New dev banner

Debug Info Dialog

Debug Dialog

@lennartkloock lennartkloock requested review from a team November 6, 2023 13:49
@TroyKomodo
Copy link
Member

This is interesting.
Do you think there are other things worth debugging?

@lennartkloock
Copy link
Member Author

This is interesting. Do you think there are other things worth debugging?

We could show latest git commit hash and git branch

@lennartkloock
Copy link
Member Author

Added this using vite build script
image

@TroyKomodo TroyKomodo merged commit 99b08bb into ScuffleCloud:feature/website Nov 6, 2023
2 of 3 checks passed
@lennartkloock lennartkloock deleted the debug-dialog branch November 14, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants